Skip to content

fix(i18n): add missing translations for zh-CN#2084

Merged
ghostdevv merged 2 commits intonpmx-dev:mainfrom
ShroXd:add-zhcn-translations
Mar 20, 2026
Merged

fix(i18n): add missing translations for zh-CN#2084
ghostdevv merged 2 commits intonpmx-dev:mainfrom
ShroXd:add-zhcn-translations

Conversation

@ShroXd
Copy link
Contributor

@ShroXd ShroXd commented Mar 15, 2026

🔗 Linked issue

n/a

🧭 Context

Add missing translations for zh-CN.

📚 Description

Also optimized the translation for compare page, since the original translation "比较包" suffers from syntactic ambiguity.

@vercel
Copy link

vercel bot commented Mar 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs.npmx.dev Ready Ready Preview, Comment Mar 20, 2026 7:58am
npmx.dev Ready Ready Preview, Comment Mar 20, 2026 7:58am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
npmx-lunaria Ignored Ignored Mar 20, 2026 7:58am

Request Review

@github-actions
Copy link

github-actions bot commented Mar 15, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/zh-CN.json Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5aec2d77-32bb-4183-a1a9-ebafcef10f82

📥 Commits

Reviewing files that changed from the base of the PR and between 4369cf4 and d744b78.

📒 Files selected for processing (1)
  • i18n/locales/zh-CN.json

📝 Walkthrough

Walkthrough

This pull request updates the Simplified Chinese locale file i18n/locales/zh-CN.json. It replaces several compare-related UI strings to use “对比/包对比” instead of “比较包” (affecting nav.compare, compare.packages titles, taglines, meta strings and section_comparison), and changes profile.links.main from "main" to "主页". Total net changes: 9 lines added, 9 lines removed.

Possibly related PRs

Suggested reviewers

  • 9romise
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining that it adds missing zh-CN translations and optimizes the compare page translation to resolve syntactic ambiguity.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can use TruffleHog to scan for secrets in your code with verification capabilities.

Add a TruffleHog config file (e.g. trufflehog-config.yml, trufflehog.yml) to your project to customize detectors and scanning behavior. The tool runs only when a config file is present.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
i18n/locales/zh-CN.json (1)

290-292: Note: Duplicate translation for distinct keys.

Both main (Line 290) and homepage (Line 292) are translated as "主页". This may be intentional if the English source uses similar wording, but if the English strings differ semantically, consider using distinct translations to preserve the nuance (e.g., "主要" for main vs "主页" for homepage).


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f50e3d7-0dc9-45ad-add7-e56b23a10a27

📥 Commits

Reviewing files that changed from the base of the PR and between a170292 and 4369cf4.

📒 Files selected for processing (1)
  • i18n/locales/zh-CN.json

@codecov
Copy link

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ghostdevv ghostdevv changed the title feat(i18n): add missing translations for zh-CN fix(i18n): add missing translations for zh-CN Mar 20, 2026
@ghostdevv ghostdevv enabled auto-merge March 20, 2026 08:00
Copy link
Contributor

@ghostdevv ghostdevv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the merge conflicts by accepting the versions that are on main @ShroXd - could you make a follow up if you think there are any mistakes with the translations on main? 🙏

d744b78

@ghostdevv ghostdevv added this pull request to the merge queue Mar 20, 2026
Merged via the queue into npmx-dev:main with commit f0ada7e Mar 20, 2026
18 of 20 checks passed
@ShroXd
Copy link
Contributor Author

ShroXd commented Mar 20, 2026

I've fixed the merge conflicts by accepting the versions that are on main @ShroXd - could you make a follow up if you think there are any mistakes with the translations on main? 🙏

d744b78

Hi, thanks! I checked the main branch, the translations look good.

@ShroXd ShroXd deleted the add-zhcn-translations branch March 20, 2026 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants